fix build warnings for GCC 15 #4010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
reviewed
Sep 29, 2025
| int size = _width * _height; | ||
| memcpy(&bytes[0], &source[0], size); | ||
|
|
||
| if( bytes != nullptr) |
There was a problem hiding this comment.
bytes just initialized at line 33 with nullptr. Most probably it's a typo.
There was a problem hiding this comment.
Thank you for your review !
bytes just initialized at line 33 with nullptr. Most probably it's a typo.
bytes are allocated in init() function.
ByteMatrix::ByteMatrix(int _width, int _height, ArrayRef<char> source) : bytes(nullptr) {
init(_width, _height);
if( bytes != nullptr)
{
const size_t size = _width * _height;
memcpy(&bytes[0], &source[0], size);
}
}But If one of _height and/or _width is less than 1 at (1) , bytes will not be allocated and keeps nullptr at (2).
void ByteMatrix::init(int _width, int _height) {
if (_width < 1 || _height < 1) { // (1)
return;
}
this->width = _width;
this->height = _height;
bytes = new unsigned char[width * height]; // (2)
row_offsets = new int[height];
row_offsets[0] = 0;
for (int i = 1; i < height; i++) {
row_offsets[i] = row_offsets[i - 1] + width;
}
}
asmorkalov
approved these changes
Sep 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4009
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.